penguin/webhook-freedns

freedns webhook for cert-manager

commit 8909f58328520dd1bc62ae283a97d9c29af901af

authorJames Lakin <james@jameslakin.co.uk>
date2022-04-16T09:19:05Z
subjectAdd explicit namespaces to all namespaced resources in Helm charts
commit 8909f58328520dd1bc62ae283a97d9c29af901af
Author: James Lakin <james@jameslakin.co.uk>
Date:   2022-04-16T09:19:05Z

    Add explicit namespaces to all namespaced resources in Helm charts
    
    A few resources didn't specify a namespace, resulting in a discrepency if `helm template --namespace` is ran and later `kubectl apply` is in a different context.
    
    Signed-off-by: James Lakin <james@jameslakin.co.uk>
---
 deploy/example-webhook/templates/deployment.yaml | 1 +
 deploy/example-webhook/templates/rbac.yaml       | 1 +
 deploy/example-webhook/templates/service.yaml    | 1 +
 3 files changed, 3 insertions(+)

diff --git a/deploy/example-webhook/templates/deployment.yaml b/deploy/example-webhook/templates/deployment.yaml
index ed49463..057cc42 100644
--- a/deploy/example-webhook/templates/deployment.yaml
+++ b/deploy/example-webhook/templates/deployment.yaml
@@ -2,6 +2,7 @@ apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: {{ include "example-webhook.fullname" . }}
+  namespace: {{ .Release.Namespace | quote }}
   labels:
     app: {{ include "example-webhook.name" . }}
     chart: {{ include "example-webhook.chart" . }}
diff --git a/deploy/example-webhook/templates/rbac.yaml b/deploy/example-webhook/templates/rbac.yaml
index d386362..605fcf5 100644
--- a/deploy/example-webhook/templates/rbac.yaml
+++ b/deploy/example-webhook/templates/rbac.yaml
@@ -2,6 +2,7 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   name: {{ include "example-webhook.fullname" . }}
+  namespace: {{ .Release.Namespace | quote }}
   labels:
     app: {{ include "example-webhook.name" . }}
     chart: {{ include "example-webhook.chart" . }}
diff --git a/deploy/example-webhook/templates/service.yaml b/deploy/example-webhook/templates/service.yaml
index 572089e..a76ddc7 100644
--- a/deploy/example-webhook/templates/service.yaml
+++ b/deploy/example-webhook/templates/service.yaml
@@ -2,6 +2,7 @@ apiVersion: v1
 kind: Service
 metadata:
   name: {{ include "example-webhook.fullname" . }}
+  namespace: {{ .Release.Namespace | quote }}
   labels:
     app: {{ include "example-webhook.name" . }}
     chart: {{ include "example-webhook.chart" . }}